Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to facility name for Appointments Details pages #33790

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Dec 27, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • This PR adds links to the facility website to the appointment details pages
  • Appointments (VAOS) Team
  • This is not behind a Flipper

Related issue(s)

Testing done

  • Tested locally
  • Updated unit tests to test for the new links

Screenshots

Note that the full matrix of all changed pages will need 2 (before, after) * (6 (VA appointment modes) * 3(upcoming confirmed, upcoming cancelled, past) + 1 (VA request) * 2 (pending, pending cancelled)) = 40 screenshots which is probably too many. Instead I'll sample a subset of the full matrix of changed pages.

Before After
VA Request - Pending image image
VA Request - Pending cancelled image image
Video ATLAS - Upcoming image image
Video VA - Upcoming cancelled image image
Claims - Past image image
In Person - Upcoming image image
Phone - Upcoming cancelled image image
Video - Past image image

What areas of the site does it impact?

Appointments (VAOS)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@@ -109,7 +109,7 @@ export default function ClaimExamLayout({ data: appointment }) {
)}
{!!facility && (
<>
{facility.name}
<a href={facility.website}>{facility.name}</a>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenniemc since you looked at the spike ticket for this work item, do you know if it's ever possible that a facility will be missing the website attribute? I'm wondering if we need to add a condition to check for that to make sure we don't display a link that doesn't actually navigate anywhere.

Copy link
Contributor

@simiadebowale simiadebowale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunTaoLuo JunTaoLuo merged commit a29abc1 into main Dec 30, 2024
79 checks passed
@JunTaoLuo JunTaoLuo deleted the jtluo/facility-link branch December 30, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants